Bitesize changes (change requests to events, linked bridge title, useEffect cleanup) #39
Merged
Conversation
williampj
changed the title
williampj
changed the title
williampj
changed the title
williampj
changed the title
AndiLavera
reviewed
Nov 21, 2020
AndiLavera
left a comment
AndiLavera
left a comment
Collaborator
There was a problem hiding this comment.
Minus the 1 comment i made, everything else looks great and is ready for merging. Can you just clarify my one question before hand?
| }; | ||
|
|
||
| useEffect(() => { | ||
| let loaded = false; // TODO use loaded in the fetch call |
Collaborator
There was a problem hiding this comment.
I don't understand this one. Is it done?
Collaborator
Author
There was a problem hiding this comment.
No, that use effect is for a separate fetch call that hasn't been written yet, so I just deleted it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the lint-fix PR could be completed and merged, then I will fast forward master into this and perhaps add more TODOs.